maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [maven-surefire] akomakom edited a comment on issue #285: [SUREFIRE-1234] Allow to configure JVM for tests by referencing a toolchain entry
Date Mon, 20 Apr 2020 18:45:43 GMT

akomakom edited a comment on issue #285:
URL: https://github.com/apache/maven-surefire/pull/285#issuecomment-616740035


   > Can you add two unit tests with PowerMock with
   > `assumeThat( method-exists )`
   > and second with
   > `assumeThat( method-doesn't-exist )`?
   > Maybe the third for verifying thrown exception `MojoFailureException`.
   
   @Tibor17 can you clarify what you're looking for here?  Which method exists/doesn't?  **getToolchains**
on ToolchainManager?  Are you looking for a test that 
   
   * will fail once we move to a new version of toolchains and the method will exist (to remind
us to change implementations)?  
   * mocks both cases (method exists or not) to verify reasonable behavior?
   
   I tried to go down path number 1, but I'm finding that when I run tests, the method never
exists... 
   
   I should probably add that I've never worked with mockito so I'm guessing my way through
line by line.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message