maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [maven-surefire] jon-bell commented on a change in pull request #240: [SUREFIRE-1658] TCP/IP Channel for forked Surefire JVM. Extensions API and SPI. Polymorphism for remote and local process communication.
Date Thu, 20 Feb 2020 13:07:06 GMT
jon-bell commented on a change in pull request #240: [SUREFIRE-1658] TCP/IP Channel for forked
Surefire JVM. Extensions API and SPI. Polymorphism for remote and local process communication.
URL: https://github.com/apache/maven-surefire/pull/240#discussion_r381986197
 
 

 ##########
 File path: surefire-booter/src/main/java/org/apache/maven/surefire/booter/BooterDeserializer.java
 ##########
 @@ -58,6 +60,18 @@ public BooterDeserializer( InputStream inputStream )
         properties = SystemPropertyManager.loadProperties( inputStream );
     }
 
+    /**
+     * Describes the current connection channel used by the client in the forked JVM
+     * in order to connect to the plugin process.
+     *
+     * @return connection string (must not be null)
+     */
+    @Nonnull
+    public String getConnectionString()
+    {
+        return properties.getProperty( FORK_NODE_CONNECTION_STRING );
 
 Review comment:
   @Tibor17 It might be attractive to be able to uniquely identify each client stream based
on its unique ID. I don't think that it adds much from a security perspective.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message