maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [maven-surefire] Tibor17 edited a comment on issue #262: Refer to correct property in skipping-tests doc
Date Tue, 28 Jan 2020 13:22:00 GMT
Tibor17 edited a comment on issue #262: Refer to correct property in skipping-tests doc
URL: https://github.com/apache/maven-surefire/pull/262#issuecomment-579180987
 
 
   The author of the doc separated the text been dedicated to the Surefire and Failsafe plugin
using IF-ELSE decision making in one doc file. That's the (1). We do not copy the doc from
Surefire module to the Failsafe module and we only switch few lines of text which is maybe
10%.
   
   The consequence of this PR is (2) and that means the we will have a big problem to split
skipping Surefire tests and Failsafe test in the future. This is the impact I can see with
this PR. The goal should be to have two properties. 
   
   Since the Maven knows only Surefire bound to the phase `test` by default and the Failsafe
is not bound to any phase, it's the property `skipTests` which should stick only to Surefire
and unit tests. The Failsafe has `skipITs` property and the bug is with `skipTests` been used
in Failsafe. Removing `skipTests` from the logic in Failsafe would isolate both plugins and
the impact in the community will be small because we have cca 25% of Failsafe users and Surefire
has 75% users. Some users asked me for providing a common property skipping both plugins but
we do not have to introduce it because the property exists `maven.test.skip.exec`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message