maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [maven-checkstyle-plugin] hazendaz commented on issue #23: [MCHECKSTYLE-388] Update internal dependencies with low impact
Date Mon, 20 Jan 2020 22:38:06 GMT
hazendaz commented on issue #23: [MCHECKSTYLE-388] Update internal dependencies with low impact
URL: https://github.com/apache/maven-checkstyle-plugin/pull/23#issuecomment-576450685
 
 
   @eolivelli No inconvenience.  Everything is there.  I always double check before pushing
back up to my remote fork when a squash has occurred.  What threw me off here was that the
PR was still open when I rebased.  So I suspected this was done outside of github and a squash
outside of github would result in the commits not matching the PR so it won't auto show as
merged.  My subsequent rebase and push then resulted in it auto closing as well as showing
no commits on it at all.  So its just the optics of the original PR.  Otherwise all good.
 At best anyways all I could have done was close the PR itself anyways.  And I probably would
never had known if it were not for jira sending a notice that the PR was changed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message