maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Elliotte Rusty Harold (Jira)" <j...@apache.org>
Subject [jira] [Commented] (MRELEASE-899) release:prepare should not change the line separator but detect effective line separator from pom.xml
Date Sun, 22 Dec 2019 11:52:00 GMT

    [ https://issues.apache.org/jira/browse/MRELEASE-899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17001900#comment-17001900
] 

Elliotte Rusty Harold commented on MRELEASE-899:
------------------------------------------------

Now that you mention it, this may explain something I'm seeing in a very different context.
Line separaors are painful. 

> release:prepare should not change the line separator but detect effective line separator
from pom.xml
> -----------------------------------------------------------------------------------------------------
>
>                 Key: MRELEASE-899
>                 URL: https://issues.apache.org/jira/browse/MRELEASE-899
>             Project: Maven Release Plugin
>          Issue Type: Improvement
>            Reporter: Ralph van Etten
>            Priority: Major
>
> Currently the plugin use the system property {{line.separator}} when it rewrites the
pom.xml.
> This causes trouble, because every line in changed, when a project is released sometimes
under Windows and sometimes under Linux (because of its different line separators). (http://stackoverflow.com/questions/11868590/maven-release-plugin-and-windows-line-breaks)
> Therefore it would be a nice feature when the plugin would not use the systems line separator
but the line separator that is already used in the pom.xml.
> On the other hand, changing the existing behaviour would maybe, also harm someone else.
> Therefore it would be an great feature when there would be an property that define the
expected behaviour, maybe in the same way it is done by the maven-assembly-plugin's property
fileSet.lineEnding (http://maven.apache.org/plugins/maven-assembly-plugin/component.html#class_fileSet)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message