maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [maven-compiler-plugin] sormuras edited a comment on issue #28: MCOMPILER-359 - Fix for NPE
Date Wed, 18 Dec 2019 04:32:20 GMT
sormuras edited a comment on issue #28: MCOMPILER-359 - Fix for NPE
URL: https://github.com/apache/maven-compiler-plugin/pull/28#issuecomment-566862745
 
 
   This is line that yields the NPE:
   https://github.com/apache/maven-compiler-plugin/blob/maven-compiler-plugin-3.8.1/src/main/java/org/apache/maven/plugin/compiler/TestCompilerMojo.java#L254
   
   The initial value assigned "cause" is tested for being "null":
   
   ```
   253:                    Throwable cause = pathException.getValue().getCause();
   254:                    while ( cause.getCause() != null )
   255:                    {
   256:                        cause = cause.getCause();
   257:                    }
   ```
   
   Current master branch doesn't differ, i.e. it also will throw a NPE.
   
   Robert: Should the initial cause of a "path exception value" always be assigned?
   If not, just report the path exception without the message pointing to the cause?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message