From issues-return-154364-archive-asf-public=cust-asf.ponee.io@maven.apache.org Thu Oct 10 05:46:03 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 42F18180626 for ; Thu, 10 Oct 2019 07:46:03 +0200 (CEST) Received: (qmail 35634 invoked by uid 500); 10 Oct 2019 05:46:02 -0000 Mailing-List: contact issues-help@maven.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@maven.apache.org Delivered-To: mailing list issues@maven.apache.org Received: (qmail 35623 invoked by uid 99); 10 Oct 2019 05:46:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 10 Oct 2019 05:46:01 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D1531E3069 for ; Thu, 10 Oct 2019 05:46:00 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 0D5D0780872 for ; Thu, 10 Oct 2019 05:46:00 +0000 (UTC) Date: Thu, 10 Oct 2019 05:46:00 +0000 (UTC) From: "Herve Boutemy (Jira)" To: issues@maven.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (MSHARED-837) add an API to configure Reproducible Builds with outputTimestamp MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MSHARED-837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16948227#comment-16948227 ] Herve Boutemy commented on MSHARED-837: --------------------------------------- no, I didn't have time until now: you know, it's my free time for https://github.com/apache/maven-archiver/commit/2f45473f180cbd1fdc2b828095e2f0e57d077a0e, you transform X to XXX without proving anything about the impact: I don't know why XXX is better than X, nor what it means for https://github.com/apache/maven-archiver/commit/9e7cc4daf109b8970ae6517ac6d4c132ec942b14 , you add a new dependency and tell me that it is better because it fails a unit test, that makes me think it removes some supported formats for setting a timestamp I don't see why I would not simply rely on JDK's DateFormat X: it works, is easy to use, easy to understand for users. > add an API to configure Reproducible Builds with outputTimestamp > ---------------------------------------------------------------- > > Key: MSHARED-837 > URL: https://issues.apache.org/jira/browse/MSHARED-837 > Project: Maven Shared Components > Issue Type: New Feature > Components: maven-archiver > Affects Versions: maven-archiver-3.4.0 > Reporter: Herve Boutemy > Assignee: Herve Boutemy > Priority: Major > Fix For: maven-archiver-3.4.1 > > > creating an archive in a Reproducible Builds way requires to configure archiver with an output timestamp: see https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=74682318 > The timestamp value can't be natively injected as Date with Plexus, because Plexus Date injection uses local timezone, then is not reproducible: see https://codehaus-plexus.github.io/plexus-containers/plexus-container-default/xref/org/codehaus/plexus/component/configurator/converters/basic/DateConverter.html > Then we need top inject ${project.build.outputTimestamp} as a String and provide an API to parse this String to a Date, before calling plexus-archiver's configureReproducible https://github.com/codehaus-plexus/plexus-archiver/pull/121 -- This message was sent by Atlassian Jira (v8.3.4#803005)