maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [maven-surefire] Tibor17 commented on a change in pull request #249: Surefire-1701: Fix @DisplayName breaking reruns
Date Wed, 23 Oct 2019 22:52:44 GMT
Tibor17 commented on a change in pull request #249: Surefire-1701: Fix @DisplayName breaking
reruns
URL: https://github.com/apache/maven-surefire/pull/249#discussion_r338315031
 
 

 ##########
 File path: surefire-providers/surefire-junit-platform/src/test/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProviderTest.java
 ##########
 @@ -865,6 +866,7 @@ void testAlwaysSkipped()
             throw new IllegalStateException( "this test should be never called" );
         }
 
+        @org.junit.jupiter.api.DisplayName( "Fails twice" )
 
 Review comment:
   well, okay it cover the test scenario but since we made two changes (array indexes and
added HashSet) we should assert the display names in the listener too.
   
   What if we coment the DisplayName? It will not rerun the tests as we found it in Jira?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message