maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [maven-shade-plugin] nielsbasjes opened a new pull request #25: [MSHADE 36] Use reduced dependencies
Date Tue, 27 Aug 2019 09:43:21 GMT
nielsbasjes opened a new pull request #25: [MSHADE 36] Use reduced dependencies
URL: https://github.com/apache/maven-shade-plugin/pull/25
 
 
   This is a proposed fix for the issue https://issues.apache.org/jira/browse/MSHADE-36 which
has been open for about 8 years.
   
   The implementation is activated when the setting "useDependencyReducedPomInJar" is set
to true.
   It then essentially injects two ResourceTransformers from code
   1) Remove the original "META-INF/maven/${project.groupId}/${project.artifactId}/pom.xml".
   2) Include the dependency-reduced-pom.xml under the name of the original pom.xml into the
final jar file.
   
   This includes an integration test to verify this actually happens.
   
   ----------------
   
   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
    - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MSHADE)
filed 
          for the change (usually before you start working on it).  
         https://issues.apache.org/jira/browse/MSHADE-36
    - [x] Each commit in the pull request should have a meaningful subject line and body.
    - [x] Format the pull request title like `[MSHADE-XXX] - Fixes bug in ApproximateQuantiles`,
          where you replace `MSHADE-XXX` with the appropriate JIRA issue. Best practice
          is to use the JIRA issue title in the pull request title and in the first line of
the 
          commit message.
    - [x] Write a pull request description that is detailed enough to understand what the
pull request does, how, and why.
    - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will

          be performed on your pull request automatically.
    - [x] You have run the integration tests successfully (`mvn -Prun-its clean verify`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if
you are unsure please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
    - [x] I hereby declare this contribution to be licensed under the [Apache License Version
2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
    - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message