maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [maven-resolver] suztomo commented on a change in pull request #39: [MRESOLVER-93] - PathRecordingDependencyVisitor to handle 3 cycles
Date Wed, 21 Aug 2019 13:56:36 GMT
suztomo commented on a change in pull request #39: [MRESOLVER-93] - PathRecordingDependencyVisitor
to handle 3 cycles
URL: https://github.com/apache/maven-resolver/pull/39#discussion_r316199100
 
 

 ##########
 File path: maven-resolver-util/src/test/java/org/eclipse/aether/util/graph/visitor/PathRecordingDependencyVisitorTest.java
 ##########
 @@ -141,12 +141,12 @@ public void testGetPaths_HandlesCycles_threePaths()
     {
         DependencyNode root = parse( "cycle-3paths.txt" );
 
-        PathRecordingDependencyVisitor visitor = new PathRecordingDependencyVisitor( new
ArtifactMatcher(), false );
+        PathRecordingDependencyVisitor visitor = new PathRecordingDependencyVisitor( new
ArtifactMatcher() );
         root.accept( visitor );
 
         List<List<DependencyNode>> paths = visitor.getPaths();
-        assertEquals( paths.toString(), 4, paths.size() );
-        assertPath( paths.get( 0 ), "a", "b", "c");
+        assertEquals( paths.toString(), 1, paths.size() );
 
 Review comment:
   Thank you for confirmation.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message