maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [maven-surefire] Tibor17 commented on a change in pull request #245: Surefire-1584: Add option to rerun failing tests for JUnit5
Date Wed, 21 Aug 2019 11:20:11 GMT
Tibor17 commented on a change in pull request #245: Surefire-1584: Add option to rerun failing
tests for JUnit5 
URL: https://github.com/apache/maven-surefire/pull/245#discussion_r316131103
 
 

 ##########
 File path: surefire-its/src/test/java/org/apache/maven/surefire/its/JUnitPlatformRerunFailingTestsIT.java
 ##########
 @@ -43,22 +42,22 @@ private SurefireLauncher unpack()
     @Test
     public void testRerunFailingErrorTestsWithOneRetry() throws Exception
     {
-        OutputValidator outputValidator = unpack().addGoal( GOAL ).setJUnitVersion( VERSION
).maven().addGoal(
+        OutputValidator outputValidator = unpack().setJUnitVersion( VERSION ).maven().addGoal(
                 "-Dsurefire.rerunFailingTestsCount=1" ).withFailure().executeTest().assertTestSuiteResults(
5, 1, 1, 0,
                 0 );
         verifyFailuresOneRetryAllClasses( outputValidator );
 
-        outputValidator = unpack().addGoal( GOAL ).setJUnitVersion( VERSION ).maven().addGoal(
 
 Review comment:
   If you use `debugLogging()` see `build.log` in the folder `target/`. I guess the Surefire
prints a message about provider used. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message