maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [maven-integration-testing] Tibor17 commented on a change in pull request #41: [MNG-5693] Remove check for link to cwiki
Date Mon, 19 Aug 2019 11:30:13 GMT
Tibor17 commented on a change in pull request #41: [MNG-5693] Remove check for link to cwiki
URL: https://github.com/apache/maven-integration-testing/pull/41#discussion_r315162176
 
 

 ##########
 File path: core-it-suite/src/test/java/org/apache/maven/it/MavenITmng5482AetherNotFoundTest.java
 ##########
 @@ -90,7 +90,16 @@ public void check( String dir )
         assertTrue( "ClassNotFoundException message was not found in output.", msg >=
0 );
 
         int url = indexOf( lines, ".*http://cwiki.apache.org/confluence/display/MAVEN/AetherClassNotFound.*"
);
-        assertTrue( "Url to ClassNotFoundAether was not found in output.", url >= 0 );
+
+        boolean versionWithMng5693 = matchesVersionRange( "[3.6.1,)"); // no more link to
cwiki
 
 Review comment:
   I think he is checking that next versions do not have that link either. If it is @slachiewicz
's purpose, then `super()` would not help.
   @michael-o Question I asked on ML, why do we keep ITs for old versions. We don't need them.
We are tesing SNAPSHOT version and we do not do it backwards for the old versions. Old versions
are over, and there I would propose to TAG this project with every Maven release. Then delete
non-general ITs.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message