From issues-return-151238-archive-asf-public=cust-asf.ponee.io@maven.apache.org Fri Jun 21 13:10:56 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 8A16918064F for ; Fri, 21 Jun 2019 15:10:56 +0200 (CEST) Received: (qmail 81571 invoked by uid 500); 21 Jun 2019 13:10:55 -0000 Mailing-List: contact issues-help@maven.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@maven.apache.org Delivered-To: mailing list issues@maven.apache.org Received: (qmail 81560 invoked by uid 99); 21 Jun 2019 13:10:55 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 21 Jun 2019 13:10:55 +0000 From: GitBox To: issues@maven.apache.org Subject: [GitHub] [maven] josephw commented on a change in pull request #256: MNG-6685: convert maven-model-builder to JSR 330 Message-ID: <156112265496.31800.8764622077104279971.gitbox@gitbox.apache.org> Date: Fri, 21 Jun 2019 13:10:54 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit josephw commented on a change in pull request #256: MNG-6685: convert maven-model-builder to JSR 330 URL: https://github.com/apache/maven/pull/256#discussion_r296228242 ########## File path: maven-model-builder/src/main/java/org/apache/maven/model/interpolation/StringSearchModelInterpolator.java ########## @@ -45,10 +44,14 @@ import java.util.Map; import java.util.concurrent.ConcurrentHashMap; +import javax.inject.Named; +import javax.inject.Singleton; + /** * StringSearchModelInterpolator */ -@Component( role = ModelInterpolator.class ) +@Named +@Singleton Review comment: Yes; it's also the [advice in Sisu/PlexusMigration](https://wiki.eclipse.org/Sisu/PlexusMigration). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services