maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [maven] josephw commented on a change in pull request #256: MNG-6685: convert maven-model-builder to JSR 330
Date Fri, 21 Jun 2019 13:10:54 GMT
josephw commented on a change in pull request #256: MNG-6685: convert maven-model-builder to
JSR 330
URL: https://github.com/apache/maven/pull/256#discussion_r296228242
 
 

 ##########
 File path: maven-model-builder/src/main/java/org/apache/maven/model/interpolation/StringSearchModelInterpolator.java
 ##########
 @@ -45,10 +44,14 @@
 import java.util.Map;
 import java.util.concurrent.ConcurrentHashMap;
 
+import javax.inject.Named;
+import javax.inject.Singleton;
+
 /**
  * StringSearchModelInterpolator
  */
-@Component( role = ModelInterpolator.class )
+@Named
+@Singleton
 
 Review comment:
   Yes; it's also the [advice in Sisu/PlexusMigration](https://wiki.eclipse.org/Sisu/PlexusMigration).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message