From issues-return-148814-archive-asf-public=cust-asf.ponee.io@maven.apache.org Thu May 2 18:24:03 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id E3AAE180671 for ; Thu, 2 May 2019 20:24:02 +0200 (CEST) Received: (qmail 13395 invoked by uid 500); 2 May 2019 18:24:01 -0000 Mailing-List: contact issues-help@maven.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@maven.apache.org Delivered-To: mailing list issues@maven.apache.org Received: (qmail 13383 invoked by uid 99); 2 May 2019 18:24:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 May 2019 18:24:01 +0000 Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 3FA09E257D for ; Thu, 2 May 2019 18:24:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id C13E925813 for ; Thu, 2 May 2019 18:24:00 +0000 (UTC) Date: Thu, 2 May 2019 18:24:00 +0000 (UTC) From: "Hudson (JIRA)" To: issues@maven.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (MSHADE-316) Explicit minijar includes MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MSHADE-316?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1683= 1839#comment-16831839 ]=20 Hudson commented on MSHADE-316: ------------------------------- Build succeeded in Jenkins: Maven TLP =C2=BB maven-shade-plugin =C2=BB mast= er #6 See https://builds.apache.org/job/maven-box/job/maven-shade-plugin/job/mast= er/6/ > Explicit minijar includes > ------------------------- > > Key: MSHADE-316 > URL: https://issues.apache.org/jira/browse/MSHADE-316 > Project: Maven Shade Plugin > Issue Type: Improvement > Reporter: Markus Karg > Assignee: Robert Scholte > Priority: Major > Fix For: 3.2.2 > > Time Spent: 40m > Remaining Estimate: 0h > > Minijar currently respects includes, but these have a drawback: Once you = defined an include, the _default includes_ are gone!=C2=A0But what you actu= ally want to have when combining minijar with includes is just an "exceptio= n" to minijar's filtering, not a complete replacement of the default includ= es! > So what we need to make this work intuitively is either "explicit minijar= exceptions", or a "useDefaultIncludes=3Dtrue" option that turns the notion= from "replace default includes by the single given include" to "add the si= ngle given include ontop of the default includes". -- This message was sent by Atlassian JIRA (v7.6.3#76005)