maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stephane Nicoll (JIRA)" <j...@apache.org>
Subject [jira] [Created] (MJAR-264) finalName property can be set and is not immutable
Date Fri, 10 May 2019 09:12:00 GMT
Stephane Nicoll created MJAR-264:
------------------------------------

             Summary: finalName property can be set and is not immutable
                 Key: MJAR-264
                 URL: https://issues.apache.org/jira/browse/MJAR-264
             Project: Maven JAR Plugin
          Issue Type: Bug
    Affects Versions: 3.1.1
            Reporter: Stephane Nicoll


>From what I understood, the intention of making sure the {{finalName}} is read-only was
to prevent users to be able to mutate its value while the build was running. Rather, they
should use the standard {{build/finalName}} that is immutable.

Unfortunately, both these are happening at the moment. There is a bug so that {{read-only}}
is ignored and the field can be set anyway. And because the field as a default to the standard
property, its value is evaluated lazily and can change based on the execution of another plugin.

Here is a simple project that reproduces the problem with the latest version of the plugin: [https://github.com/snicoll-scratches/test-jar-final-name]

The Spring Boot Maven Plugin has the exact same setup (actually we did align our plugin to
what the jar plugin did for consistency). We broke users by removing the field when we noticed
one can still set it and we are looking for advices as what to do. We want to make sure that
the decision we take is align with the direction of core plugins.

Thanks!

 

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message