maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Osipov (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (MJAR-183) Add LifecycleMapping and ArtifactHandler from maven-core to target packaging plugin
Date Sun, 26 May 2019 10:21:00 GMT

    [ https://issues.apache.org/jira/browse/MJAR-183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848389#comment-16848389
] 

Michael Osipov edited comment on MJAR-183 at 5/26/19 10:20 AM:
---------------------------------------------------------------

[~khmarbaise], I believe this change either causes a regression or reveals a bug in our ITs:

* Update ITs to at least c0ad4eb84898579bc60691115efb759296f9f889
* Build Maven from branch MNG-6169/MNG-6556_MJAR-3.0.0

You should see Guice provisioning errors in MNG-5578/MNG-5530:

{noformat}
Caused by: com.google.inject.ProvisionException: Unable to provision, see the following errors:

1) No implementation for org.apache.maven.its.mng5530.sessionscope.TestSessionScopedComponent
was bound.
  while locating org.apache.maven.its.mng5530.sessionscope.TestSessionScopeMojo
  at ClassRealm[extension>mng-5578-session-scope:mng-5578-session-scope-plugin:0.1, parent:
java.net.URLClassLoader@27f674d] (via modules: org.eclipse.sisu.wire.WireModule -> org.eclipse.sisu.plexus.PlexusBindingModule)
  while locating org.apache.maven.plugin.Mojo annotated with @com.google.inject.name.Named(value=mng-5578-session-scope:mng-5578-session-scope-plugin:0.1:test-session-scope)

1 error
    at com.google.inject.internal.InternalProvisionException.toProvisionException (InternalProvisionException.java:226)
{noformat}

Any idea?


was (Author: michael-o):
[~khmarbaise], I believe this change either causes a regression or reveals a bug in our ITs:

* Update ITs to at least c0ad4eb84898579bc60691115efb759296f9f889
* Build Maven from branch MNG-6169/MNG-6556_MJAR-3.0.0

You should see Guice provisioning errors in MNG-5578/MNG-5530:

{noformat}
Caused by: com.google.inject.ProvisionException: Unable to provision, see the following errors:

1) No implementation for org.apache.maven.its.mng5530.sessionscope.TestSessionScopedComponent
was bound.
  while locating org.apache.maven.its.mng5530.sessionscope.TestSessionScopeMojo
  at ClassRealm[extension>mng-5578-session-scope:mng-5578-session-scope-plugin:0.1, parent:
java.net.URLClassLoader@27f674d] (via modules: org.eclipse.sisu.wire.WireModule -> org.eclipse.sisu.plexus.PlexusBindingModule)
  while locating org.apache.maven.plugin.Mojo annotated with @com.google.inject.name.Named(value=mng-5578-session-scope:mng-5578-session-scope-plugin:0.1:test-session-scope)

1 error
    at com.google.inject.internal.InternalProvisionException.toProvisionException (InternalProvisionException.java:226)
{noformat}

Any idea?

 

 

> Add LifecycleMapping and ArtifactHandler from maven-core to target packaging plugin
> -----------------------------------------------------------------------------------
>
>                 Key: MJAR-183
>                 URL: https://issues.apache.org/jira/browse/MJAR-183
>             Project: Maven JAR Plugin
>          Issue Type: Improvement
>            Reporter: Robert Scholte
>            Assignee: Karl Heinz Marbaise
>            Priority: Major
>             Fix For: 3.0.0
>
>
> Maven Core shouldn't be aware of this kind of information, instead the maven-jar-plugin
should specify and maintain the {{LifecycleMapping}} and {{ArtifactHandler}} by itself. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message