maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [maven-surefire] Tibor17 commented on issue #235: [SUREFIRE-1669] POJO tests do not call fixture methods setUp and tearDown and test instance are not new between tests
Date Mon, 27 May 2019 11:11:56 GMT
Tibor17 commented on issue #235: [SUREFIRE-1669] POJO tests do not call fixture methods setUp
and tearDown and test instance are not new between tests
URL: https://github.com/apache/maven-surefire/pull/235#issuecomment-496176241
 
 
   @pzygielo 
   > I don't understand that accusation.
   
   It wasn't accusation ;-) You have misunderstod me really. The argumentation was unnecessaily
too long towards the basics of methods setUp/tearDown. Therefore through your excellent code
analysis you could stop writing that PR and better write an issue asking a question - This
was my meaning of to behonest. We would not ignore it for sure!
   I think you recognized that changing documentation is not the right thing and that it was
written correctly. Usually people break the code and not the documentation, maybe because
the docu is more simple. 
   I meant that sometime our contributors and users honestly underline that their fix is a
workaround and they drop their PR in favor of better PR. In your case I understand that you
have to change your commecial code and remove `static` but this is the penalty the user group
has to pay for the fault; doesn't matter if we made the bug in ASF or users. I think you made
a good analysis of the code and you understood it correctly, and I know that it was easier
for you to change documentation but it was not right to continue in this direction. What is
better is to open an issue on GitHub (not a PR the first time) and ask us for guidance and
how the fix should look like. This saves the time on both sides.
   
   I don't want to dissapoint you, just the clarification was needed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message