maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [maven-surefire] pzygielo commented on issue #235: [SUREFIRE-1669] POJO tests do not call fixture methods setUp and tearDown and test instance are not new between tests
Date Mon, 27 May 2019 08:52:23 GMT
pzygielo commented on issue #235: [SUREFIRE-1669] POJO tests do not call fixture methods setUp
and tearDown and test instance are not new between tests
URL: https://github.com/apache/maven-surefire/pull/235#issuecomment-496135278
 
 
   > ok, you as a user, try to be more honest and self critical.
   
   I don't understand that accusation. #234 was a very honest discussion, especially honest
question https://github.com/apache/maven-surefire/pull/234#issuecomment-495985222: 
   > Shall it be really the case? Were setUp and tearDown really intended to be class methods?
   
   Which was not properly addressed on the course of review.
   
   Also I was under impression that everything is all right with implementation
   https://github.com/apache/maven-surefire/pull/234#issuecomment-496008435:
   > We have to drop this requirement because the documentation is right.
   > The implementation is right as well.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message