From issues-return-147409-archive-asf-public=cust-asf.ponee.io@maven.apache.org Mon Apr 1 19:33:21 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 410C7180672 for ; Mon, 1 Apr 2019 21:33:21 +0200 (CEST) Received: (qmail 87728 invoked by uid 500); 1 Apr 2019 19:33:20 -0000 Mailing-List: contact issues-help@maven.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@maven.apache.org Delivered-To: mailing list issues@maven.apache.org Received: (qmail 87708 invoked by uid 99); 1 Apr 2019 19:33:20 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Apr 2019 19:33:20 +0000 From: GitBox To: issues@maven.apache.org Subject: [GitHub] [maven-pmd-plugin] oss92 commented on a change in pull request #6: [MPMD-275] update to PMD 6.13.0 Message-ID: <155414719970.21613.10405915369953855691.gitbox@gitbox.apache.org> Date: Mon, 01 Apr 2019 19:33:19 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit oss92 commented on a change in pull request #6: [MPMD-275] update to PMD 6.13.0 URL: https://github.com/apache/maven-pmd-plugin/pull/6#discussion_r271018165 ########## File path: src/it/MPMD-268-deprecated-rules/verify.groovy ########## @@ -19,4 +19,6 @@ File buildLog = new File( basedir, 'build.log' ) assert buildLog.exists() -assert buildLog.text.contains( "[WARNING] Use Rule name category/java/codestyle.xml/ControlStatementBraces instead of the deprecated" ) +// Some versions output `WARNING:` and others `[WARNING]` Review comment: I have ran the tests twice using JDK11 and JDK12 on macOS 10.14.1. I don't know which output what now since I am afk. Thanks for the response. When do you expect the release of 6.13.0 change to maven? Cheers! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services