maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [maven-shade-plugin] rfscholte commented on a change in pull request #17: [MSHADE-313] - Keep Services
Date Tue, 02 Apr 2019 21:00:39 GMT
rfscholte commented on a change in pull request #17: [MSHADE-313] - Keep Services
URL: https://github.com/apache/maven-shade-plugin/pull/17#discussion_r271494010
 
 

 ##########
 File path: src/main/java/org/apache/maven/plugins/shade/filter/MinijarFilter.java
 ##########
 @@ -138,13 +140,19 @@ private void removeServices( final MavenProject project, final Clazzpath
cp )
                         }
 
                         try ( final BufferedReader bufferedReader =
-                           new BufferedReader( new InputStreamReader( jar.getInputStream(
jarEntry ) ) ) )
+                           new BufferedReader( new InputStreamReader( jar.getInputStream(
jarEntry ), UTF_8 ) ) )
                         {
                             for ( String className = bufferedReader.readLine(); className
!= null;
                                 className = bufferedReader.readLine() )
                             {
-                               log.info( className + " was not removed because it is a service"
);
-                               removeClass( cp , className );
+                                className = className.split( "#", 2 )[0].trim();
 
 Review comment:
   I have a better proposal: let me improve the ITs with the mock repository manager, so we
can create such jar ourselves.
   Other option: turn the IT into a Maven multimodule project.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message