From issues-return-145390-archive-asf-public=cust-asf.ponee.io@maven.apache.org Wed Feb 6 07:45:04 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id F0B90180679 for ; Wed, 6 Feb 2019 08:45:03 +0100 (CET) Received: (qmail 9293 invoked by uid 500); 6 Feb 2019 07:45:02 -0000 Mailing-List: contact issues-help@maven.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@maven.apache.org Delivered-To: mailing list issues@maven.apache.org Received: (qmail 9282 invoked by uid 99); 6 Feb 2019 07:45:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Feb 2019 07:45:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 19904C5A63 for ; Wed, 6 Feb 2019 07:45:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id n-TMzFTXet4g for ; Wed, 6 Feb 2019 07:45:00 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id B1EE05F5A7 for ; Wed, 6 Feb 2019 07:45:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 526F6E262F for ; Wed, 6 Feb 2019 07:45:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 11F5124423 for ; Wed, 6 Feb 2019 07:45:00 +0000 (UTC) Date: Wed, 6 Feb 2019 07:45:00 +0000 (UTC) From: =?utf-8?Q?Clemens_Quo=C3=9F_=28JIRA=29?= To: issues@maven.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (SCM-917) Implement scm:untag for Subversion provider MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SCM-917?page=3Dcom.atlassian.ji= ra.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1676155= 3#comment-16761553 ]=20 Clemens Quo=C3=9F edited comment on SCM-917 at 2/6/19 7:44 AM: ---------------------------------------------------------- Michael, I tried to push the SCM-917 branch for the pull request, but it se= ems I lack authority: remote: Permission to apache/maven-scm.git denied to cquoss. What is the proper way to hand in the pull request? Some questions remain: * What use has the SCM Manager API?=C2=A0 It seems outdated. * How are the=C2=A0TckTest classes being run? Some of them (JGit for examp= le) are running during normal build.=C2=A0 I provided 'normal' and Tck svn = untag tests, but I see only the normal tests. * Do you want me to provide an UntagMojo Test for Subversion in the plugin= tests? * Should I fix the checkstyle error in jgit?=C2=A0 Classes JGitCheckoutCom= mand, JGitTransportConfigCallbak, JGitUtils and JGitRemoteInfoCommand produ= ce > 100 checkstyle errors in sum. Regards, Clemens was (Author: cquoss): Michael, I tried to push the SCM-917 branch for the pull request, but it se= ems I lack authority: remote: Permission to apache/maven-scm.git denied to cquoss. What is the proper way to hand in the pull request? Some questions remain: * What use has the SCM Manager API?=C2=A0 It seems outdated. * How are the=C2=A0TckTest classes being run? Some of them (JGit for examp= le) are running during normal build.=C2=A0 I provided 'normal' and Tck svn = untag tests, but I see only the normal tests. * Do you want me to provide an UntagMojo Test for Sobversion in the plugin= tests? * Should I fix the checkstyle error in jgit?=C2=A0 Classes JGitCheckoutCom= mand, JGitTransportConfigCallbak, JGitUtils and JGitRemoteInfoCommand produ= ce > 100 checkstyle errors in sum. Regards, Clemens > Implement scm:untag for Subversion provider > ------------------------------------------- > > Key: SCM-917 > URL: https://issues.apache.org/jira/browse/SCM-917 > Project: Maven SCM > Issue Type: Improvement > Components: maven-scm-provider-svn > Affects Versions: 1.11.1 > Reporter: Clemens Quo=C3=9F > Priority: Critical > Fix For: waiting-for-feedback > > Attachments: git-diff-master.out, image-2019-02-02-16-57-33-664.p= ng > > > In order to work on MRELEASE-229, I would like to provide a PR for SCM to= enable remote removal for provider svn. > Short outline: > Introducing new parameter on scm:remove "remoteRemove" (alternative: use = pushChanges for this for svn, but this might be confusing). > Implementation: > New execute method in SvnRemoveCommand using a new ScmRemoveParameters ca= rrying this new parameter.=C2=A0 If true, use url from repository as base t= o construct targets from scm file set in command line. > [UPDATE] -=C2=A0Implementation of scm:untag command will now be the targe= t of this issue (follow comment discussion) -- This message was sent by Atlassian JIRA (v7.6.3#76005)