From issues-return-146184-archive-asf-public=cust-asf.ponee.io@maven.apache.org Sat Feb 23 12:04:14 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 9861B18077A for ; Sat, 23 Feb 2019 13:04:13 +0100 (CET) Received: (qmail 28331 invoked by uid 500); 23 Feb 2019 12:04:12 -0000 Mailing-List: contact issues-help@maven.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@maven.apache.org Delivered-To: mailing list issues@maven.apache.org Received: (qmail 28320 invoked by uid 99); 23 Feb 2019 12:04:12 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 23 Feb 2019 12:04:12 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 2A9071819C3 for ; Sat, 23 Feb 2019 12:04:12 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -108.001 X-Spam-Level: X-Spam-Status: No, score=-108.001 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, KAM_WEIRDTRICK1=1.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id p1sMKoUDCHsi for ; Sat, 23 Feb 2019 12:04:10 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id E477560E1E for ; Sat, 23 Feb 2019 11:58:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D8306E277B for ; Sat, 23 Feb 2019 11:58:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 61F8C24549 for ; Sat, 23 Feb 2019 11:58:00 +0000 (UTC) Date: Sat, 23 Feb 2019 11:58:00 +0000 (UTC) From: "Hudson (JIRA)" To: issues@maven.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (MNG-5661) Make MavenProject instances immutable after initial construction MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MNG-5661?page=3Dcom.atlassian.j= ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D167758= 70#comment-16775870 ]=20 Hudson commented on MNG-5661: ----------------------------- Build failed in Jenkins: Maven TLP =C2=BB maven =C2=BB MNG-6597 #2 See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6597/2/ > Make MavenProject instances immutable after initial construction > ---------------------------------------------------------------- > > Key: MNG-5661 > URL: https://issues.apache.org/jira/browse/MNG-5661 > Project: Maven > Issue Type: New Feature > Reporter: Jason van Zyl > Assignee: Jason van Zyl > Priority: Major > Attachments: Maven-Reactor-Dump.png > > > When a MavenProject is initially constructed it is not immutable and req= uires subsequent mutation to be complete in different circumstance. This ma= kes the logic in MavenProject complex and makes MavenProject hard to unders= tand. We need to move toward being complete and immutable after constructio= n.=20 > This not being the case has a number of consequences two of which are: > 1) Components are required in MavenProject in order to lazily construct c= ertain values. This complicates MavenProject when it simply should be a con= figuration, or data. The logic to construct anything should be moved to the= ProjectBuilder, take the small hit in performance, and all construction sh= ould happen up-front. > 2) The lifecycle needs to be executed in order for a MavenProject instanc= e to be fully populated with respect to source directories and project reso= urces. This makes it particularly hard for systems like IDEs to integrate w= ithout resorting to weird tricks to figure out generated source directories= without executing Maven itself. -- This message was sent by Atlassian JIRA (v7.6.3#76005)