maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Peter lynch (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WAGON-541) Command Line Not Showing ReasonPhrase for Errors
Date Mon, 04 Feb 2019 20:52:00 GMT

    [ https://issues.apache.org/jira/browse/WAGON-541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16760210#comment-16760210
] 

Peter lynch commented on WAGON-541:
-----------------------------------

[~michael-o] a system property or anything that makes reason phrase optionally displayed is
not ideal.

People were using the status code and reason phrase to better understand why a build fails.
This can help resolve build failures and get on with the important stuff more quickly.

When a build fails, it is too late to retroactively go back and set a system property to determine
why it failed in the past. Users can't reasonably be expected to pre-set a new system property
to see reason phrases for future possible failures either. They can't with complete certainty
in advance if any intermediary server, firewall, HTTP Proxy, or repository manager will be
customizing the reason phrase, which may provide useful guidance for fixing a build failure.
The persons running builds are often not in control of infrastructure between their build
and the remote endpoint. They can't predict how it will fail or what reason phrase will be
returned.

I propose the spirit of the original change as I understand it be enhanced. Lets clean up
code and make exception messages more consistent and less redundant across the 3 major HTTP
wagon implementations. Exception messages could become consistently formatted with URL, status
code and reason phrase while at the same time removing message redundancy.

I would be happy to provide a PR for both cleaning up messages and providing contextual useful
Wagon exception messages that can help solve build failures in the most efficient manner.
It might take me this week to offer this PR up for review.

My view point comes from trying to help enterprise customers who have Maven build failures
trying to better understand what went wrong.

[~michael-o] how does it sound?



> Command Line Not Showing ReasonPhrase for Errors
> ------------------------------------------------
>
>                 Key: WAGON-541
>                 URL: https://issues.apache.org/jira/browse/WAGON-541
>             Project: Maven Wagon
>          Issue Type: Bug
>          Components: wagon-http
>    Affects Versions: 3.2.0
>         Environment: Windows 10
>            Reporter: Aurelie Pluche
>            Priority: Minor
>         Attachments: MvnCmdLineV339.PNG, MvnCmdLineV339V2.PNG, MvnCmdLineV360.PNG, MvnCmdLineV360V2.PNG
>
>
> Hi,
> I work in the Azure DevOps Artifacts Packaging team at Microsoft where we provide a Maven
service to our customers. We often use a Reason-Phrase to return information on failed requests
to customers. This functionality was available in previous versions of maven but seems to
have disappeared in Maven 3.6.0. Was this intentional?
> I have included screenshots of the cmd line response using two different maven versions
(3.3.9 and 3.6.0). I intentionally made a call that would return a 405 error to be able to
get an error response. I also used the same package.
> Thanks



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message