maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] zregvart commented on a change in pull request #5: [MCHECKSTYLE-353] - Don't resolve any dependencies
Date Mon, 18 Feb 2019 08:32:15 GMT
zregvart commented on a change in pull request #5: [MCHECKSTYLE-353] - Don't resolve any dependencies
URL: https://github.com/apache/maven-checkstyle-plugin/pull/5#discussion_r257595180
 
 

 ##########
 File path: src/main/java/org/apache/maven/plugins/checkstyle/CheckstyleViolationCheckMojo.java
 ##########
 @@ -72,7 +72,7 @@
  * @author <a href="mailto:joakim@erdfelt.net">Joakim Erdfelt</a>
  * @version $Id$
  */
-@Mojo( name = "check", defaultPhase = LifecyclePhase.VERIFY, requiresDependencyResolution
= ResolutionScope.TEST,
+@Mojo( name = "check", defaultPhase = LifecyclePhase.VERIFY, requiresDependencyResolution
= ResolutionScope.NONE,
 
 Review comment:
   Thanks for proposing this. I'll measure the execution times with empty local Maven repository
on Apache Camel and report my findings.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message