maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] dmitri-gb opened a new pull request #15: [MSHADE-223] - Endless processing with promoteTransitiveDependencies
Date Fri, 01 Feb 2019 14:33:39 GMT
dmitri-gb opened a new pull request #15: [MSHADE-223] - Endless processing with promoteTransitiveDependencies
URL: https://github.com/apache/maven-shade-plugin/pull/15
 
 
   Fix the endless processing that was caused by not checking the classifier of the dependencies
when adding excludes.
   
   I opted for just comparing the results of the `getId` method, as it already contains all
the necessary info (groupId + artifactId + type + classifier). The previous check `dep.getType()
== null` seems unnecessary, as the type is generally never `null`.
   
   I also added an integration test that reproduces the issue. It includes an `invoker.properties`
file that sets `invoker.timeoutInSeconds=60`, because without the fix the issue manifests
as a non-terminating build.
   
   - [x] I hereby declare this contribution to be licenced under the [Apache License Version
2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message