From issues-return-144774-archive-asf-public=cust-asf.ponee.io@maven.apache.org Fri Jan 25 08:17:06 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id DAD78180771 for ; Fri, 25 Jan 2019 08:17:05 +0100 (CET) Received: (qmail 33979 invoked by uid 500); 25 Jan 2019 07:17:04 -0000 Mailing-List: contact issues-help@maven.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@maven.apache.org Delivered-To: mailing list issues@maven.apache.org Received: (qmail 33968 invoked by uid 99); 25 Jan 2019 07:17:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 25 Jan 2019 07:17:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 02AB5180A2E for ; Fri, 25 Jan 2019 07:17:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id JG-rKHxpoc3U for ; Fri, 25 Jan 2019 07:17:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 5AEBA5F4DB for ; Fri, 25 Jan 2019 07:17:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 58C83E00A7 for ; Fri, 25 Jan 2019 07:17:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 5DB4B242FB for ; Fri, 25 Jan 2019 07:17:00 +0000 (UTC) Date: Fri, 25 Jan 2019 07:17:00 +0000 (UTC) From: =?utf-8?Q?Herv=C3=A9_Boutemy_=28JIRA=29?= To: issues@maven.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (MNG-6575) make Dependency immutable MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MNG-6575?page=3Dcom.atlassian.j= ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D167519= 81#comment-16751981 ]=20 Herv=C3=A9 Boutemy commented on MNG-6575: ------------------------------------ it's about immutable to enable cache without fearing instance modification = that affects many users on complexity of dependency: are we talking about the same? I'm talking abo= ut: [https://maven.apache.org/ref/3.6.0/maven-model/apidocs/org/apache/mave= n/model/Dependency.html] , which looks quite simple: just a dependency on E= xclusion and InputLocation > make Dependency immutable > ------------------------- > > Key: MNG-6575 > URL: https://issues.apache.org/jira/browse/MNG-6575 > Project: Maven > Issue Type: Improvement > Components: Dependencies, Inheritance and Interpolation > Affects Versions: 3.6.0 > Reporter: Herv=C3=A9 Boutemy > Priority: Major > > while working on Maven memory consumption issue MNG-6571, once VersionRan= ge is made immutable, memory used was divided by 2: the next big expected w= in is to make Dependency immutable, which would probably once again divide = memory by 2 because the vast majority of time, dependencies (be it in depen= dencyManagement or base dependencies) are inherited without any modificatio= n > this will require to change [ModelMerger|https://maven.apache.org/ref/3.6= .0/maven-model/apidocs/org/apache/maven/model/merge/ModelMerger.html] 's {{= mergeDependency(Dependency target, Dependency source, boolean sourceDominan= t, Map context)}} signature, since is not really an immutabl= e friendly signature > and also make [Dependency code|https://maven.apache.org/ref/3.6.0/maven-m= odel/apidocs/org/apache/maven/model/Dependency.html] immutable (generated b= y Modello) -- This message was sent by Atlassian JIRA (v7.6.3#76005)