From issues-return-143937-archive-asf-public=cust-asf.ponee.io@maven.apache.org Fri Jan 11 21:19:35 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 89D34180648 for ; Fri, 11 Jan 2019 21:19:34 +0100 (CET) Received: (qmail 57585 invoked by uid 500); 11 Jan 2019 20:19:33 -0000 Mailing-List: contact issues-help@maven.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@maven.apache.org Delivered-To: mailing list issues@maven.apache.org Received: (qmail 57574 invoked by uid 99); 11 Jan 2019 20:19:33 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 11 Jan 2019 20:19:33 +0000 From: GitBox To: issues@maven.apache.org Subject: [GitHub] andretadeu commented on issue #4: [MJAR-254] Finish the fix of MJAR-198. Message-ID: <154723797302.20229.14871302341020549729.gitbox@gitbox.apache.org> Date: Fri, 11 Jan 2019 20:19:33 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit andretadeu commented on issue #4: [MJAR-254] Finish the fix of MJAR-198. URL: https://github.com/apache/maven-jar-plugin/pull/4#issuecomment-453645158 I mostly reused the changes that came with MJAR-198, which already used: ```{java} final File artifact = getProject().getArtifact().getFile(); if ( artifact != null ) { final String defaultArtifactName = artifact.getName().replace( ".jar", "" ); return artifact.isFile() && defaultArtifactName.equals( finalName ); } else { return false; } ``` I can change it, but I'll end up removing the changes from MJAR-198 and redoing it in the way you suggested. If you have no objections, I'll redo this correction in this same PR, except if you prefer it in another PR. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services