maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Hervé Boutemy (JIRA) <j...@apache.org>
Subject [jira] [Commented] (MNG-6575) make Dependency immutable
Date Fri, 25 Jan 2019 07:17:00 GMT

    [ https://issues.apache.org/jira/browse/MNG-6575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16751981#comment-16751981
] 

Hervé Boutemy commented on MNG-6575:
------------------------------------

it's about immutable to enable cache without fearing instance modification that affects many
users

on complexity of dependency: are we talking about the same? I'm talking about: [https://maven.apache.org/ref/3.6.0/maven-model/apidocs/org/apache/maven/model/Dependency.html]
, which looks quite simple: just a dependency on Exclusion and InputLocation

> make Dependency immutable
> -------------------------
>
>                 Key: MNG-6575
>                 URL: https://issues.apache.org/jira/browse/MNG-6575
>             Project: Maven
>          Issue Type: Improvement
>          Components: Dependencies, Inheritance and Interpolation
>    Affects Versions: 3.6.0
>            Reporter: Hervé Boutemy
>            Priority: Major
>
> while working on Maven memory consumption issue MNG-6571, once VersionRange is made immutable,
memory used was divided by 2: the next big expected win is to make Dependency immutable, which
would probably once again divide memory by 2 because the vast majority of time, dependencies
(be it in dependencyManagement or base dependencies) are inherited without any modification
> this will require to change [ModelMerger|https://maven.apache.org/ref/3.6.0/maven-model/apidocs/org/apache/maven/model/merge/ModelMerger.html]
's {{mergeDependency(Dependency target, Dependency source, boolean sourceDominant, Map<Object,Object>
context)}} signature, since is not really an immutable friendly signature
> and also make [Dependency code|https://maven.apache.org/ref/3.6.0/maven-model/apidocs/org/apache/maven/model/Dependency.html]
immutable (generated by Modello)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message