maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] rfscholte commented on a change in pull request #4: [MJAR-254] Finish the fix of MJAR-198.
Date Wed, 16 Jan 2019 20:22:35 GMT
rfscholte commented on a change in pull request #4: [MJAR-254] Finish the fix of MJAR-198.
URL: https://github.com/apache/maven-jar-plugin/pull/4#discussion_r248437017
 
 

 ##########
 File path: src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java
 ##########
 @@ -272,11 +275,25 @@ public void execute()
 
     private boolean projectHasAlreadySetAnArtifact()
     {
-        final File artifact = getProject().getArtifact().getFile();
-        if ( artifact != null )
+        if ( getProject().getArtifact().getFile() != null )
         {
-            final String defaultArtifactName = artifact.getName().replace( ".jar", "" );
-            return artifact.isFile() && defaultArtifactName.equals( finalName );
+            if ( getProject().getArtifact().getFile().isFile() )
+            {
+                try
+                {
+                    JarFile existingJarFile = new JarFile( getProject().getArtifact().getFile()
);
+                    Attributes existingJarFileAttr = existingJarFile.getManifest().getMainAttributes();
 
 Review comment:
   So you are saying: there is actually no issue? I have always wondered why the filename
mattered... does it really matter?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message