maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] andretadeu commented on issue #4: [MJAR-254] Finish the fix of MJAR-198.
Date Fri, 11 Jan 2019 20:19:33 GMT
andretadeu commented on issue #4: [MJAR-254] Finish the fix of MJAR-198.
URL: https://github.com/apache/maven-jar-plugin/pull/4#issuecomment-453645158
 
 
   I mostly reused the changes that came with MJAR-198, which already used:
   
   ```{java}
           final File artifact = getProject().getArtifact().getFile();
           if ( artifact != null )
           {
               final String defaultArtifactName = artifact.getName().replace( ".jar", "" );
               return artifact.isFile() && defaultArtifactName.equals( finalName );
           }
           else
           {
               return false;
           }
   ```
   
   I can change it, but I'll end up removing the changes from MJAR-198 and redoing it in the
way you suggested. If you have no objections, I'll redo this correction in this same PR, except
if you prefer it in another PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message