From issues-return-141329-archive-asf-public=cust-asf.ponee.io@maven.apache.org Mon Dec 3 22:57:06 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id A64B8180645 for ; Mon, 3 Dec 2018 22:57:05 +0100 (CET) Received: (qmail 6402 invoked by uid 500); 3 Dec 2018 21:57:04 -0000 Mailing-List: contact issues-help@maven.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@maven.apache.org Delivered-To: mailing list issues@maven.apache.org Received: (qmail 6391 invoked by uid 99); 3 Dec 2018 21:57:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Dec 2018 21:57:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 4D90C18B1B5 for ; Mon, 3 Dec 2018 21:57:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 2VAZOrzToH_m for ; Mon, 3 Dec 2018 21:57:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 027F160F63 for ; Mon, 3 Dec 2018 21:57:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id ADB26E0E3E for ; Mon, 3 Dec 2018 21:57:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 45C9024DCE for ; Mon, 3 Dec 2018 21:57:00 +0000 (UTC) Date: Mon, 3 Dec 2018 21:57:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@maven.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (SUREFIRE-1602) Surefire fails loading class ForkedBooter when using a sub-directory pom file and a local maven repo MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SUREFIRE-1602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16707863#comment-16707863 ] ASF GitHub Bot commented on SUREFIRE-1602: ------------------------------------------ Tibor17 commented on a change in pull request #205: [SUREFIRE-1602] Surefire fails loading class ForkedBooter when using a sub-directory pom file and a local maven repo URL: https://github.com/apache/maven-surefire/pull/205#discussion_r238452891 ########## File path: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java ########## @@ -2369,7 +2369,21 @@ private Artifact getSurefireBooterArtifact() */ File getSurefireTempDir() { - return IS_OS_WINDOWS ? createSurefireBootDirectoryInTemp() : createSurefireBootDirectoryInBuild(); + File result = IS_OS_WINDOWS ? createSurefireBootDirectoryInTemp() : createSurefireBootDirectoryInBuild(); + try + { + File canonical = result.getCanonicalFile(); + if ( !result.equals( canonical ) ) + { + logger.debug( "Canonicalized tempDir path " + result + " to " + canonical ); Review comment: Let's use simple quotation marks as it is down with IOException which avoids white spaces: `logger.debug( "Canonicalized surefireTempDir path '" + result + "' to '" + canonical + "'." )` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org > Surefire fails loading class ForkedBooter when using a sub-directory pom file and a local maven repo > ---------------------------------------------------------------------------------------------------- > > Key: SUREFIRE-1602 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1602 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Surefire Plugin > Affects Versions: 3.0.0-M1 > Environment: maven 3.6.0 open-jdk-8 (docker image maven:3.6.0-open-jdk-8) > Reporter: Daniel Kurzynski > Assignee: Tibor Digana > Priority: Major > Fix For: 3.0.0-M2 > > Attachments: execute_error.txt, execute_ok.txt > > > Steps to reproduce: > Use a docker image for maven:3.6 (docker run -it maven:3.6.0-jdk-8 bash) > Inside generate a new project: > {code:java} > mvn archetype:generate \ > -DinteractiveMode=false \ > -DarchetypeGroupId=com.sap.cloud.s4hana.archetypes \ > -DarchetypeArtifactId=scp-cf-tomee \ > -DarchetypeVersion=2.7.0 \ > -DgroupId=com.sap.cloud.sdk.tutorial \ > -DartifactId=testapp\ > -Dversion=1.0-SNAPSHOT \ > -Dpackage=com.sap.cloud.s4hana.examples{code} > In the folder testapp set surefire version to 3.0.0-M1 in unit-tests/pom.xml and integration-tests/pom.xml > Build the project > {code:java} > mvn -Dmaven.repo.local=maven_local_repo -Dmaven.test.skip clean install{code} > Running the tests afterwards will fail > {code:java} > mvn test -Dmaven.repo.local=maven_local_repo --file ./integration-tests/pom.xml{code} > The error message in the logs is: > Error: Could not find or load main class org.apache.maven.surefire.booter.ForkedBooter > However, it only fails when using ./ in the beginning of the file parameter in combination with having a local maven repo. -- This message was sent by Atlassian JIRA (v7.6.3#76005)