From issues-return-141443-archive-asf-public=cust-asf.ponee.io@maven.apache.org Wed Dec 5 15:08:50 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 01A0B18062B for ; Wed, 5 Dec 2018 15:08:49 +0100 (CET) Received: (qmail 39300 invoked by uid 500); 5 Dec 2018 14:08:49 -0000 Mailing-List: contact issues-help@maven.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@maven.apache.org Delivered-To: mailing list issues@maven.apache.org Received: (qmail 39289 invoked by uid 99); 5 Dec 2018 14:08:49 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Dec 2018 14:08:49 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 977EE182EC0 for ; Wed, 5 Dec 2018 14:08:48 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -108.188 X-Spam-Level: X-Spam-Status: No, score=-108.188 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, URI_HEX=1.313, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id zzOtTQhtY2me for ; Wed, 5 Dec 2018 14:08:46 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id EBE5B60FAA for ; Wed, 5 Dec 2018 14:02:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 8DE0DE0E3E for ; Wed, 5 Dec 2018 14:02:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 183472775F for ; Wed, 5 Dec 2018 14:02:00 +0000 (UTC) Date: Wed, 5 Dec 2018 14:02:00 +0000 (UTC) From: "Gili (JIRA)" To: issues@maven.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (MJLINK-27) Code incorrectly assumes that two modules won't have the same name MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MJLINK-27?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16710= 097#comment-16710097 ]=20 Gili commented on MJLINK-27: ---------------------------- I asked Alan Bateman for clarification and [he wrote|http://jigsaw-dev.1059= 479.n5.nabble.com/Clarification-needed-regarding-modulepath-containing-mult= iple-modules-with-the-same-name-tp5718248p5718251.html]: {quote}if you've got say two directories on the module path and they=C2=A0 both contain module M then M will be found in the first directory, the M= =C2=A0 in the second directory will be ignored.=C2=A0 The linked comment about it being an error to have a directory on the=C2=A0 module path containing multiple versions of the same module is also correc= t. {quote} So this plugin's behavior is incorrect. > Code incorrectly assumes that two modules won't have the same name > ------------------------------------------------------------------ > > Key: MJLINK-27 > URL: https://issues.apache.org/jira/browse/MJLINK-27 > Project: Maven JLink Plugin > Issue Type: Bug > Affects Versions: 3.0.0-alpha-2 > Reporter: Gili > Priority: Major > > Karl Heinz Marbaise closed MJLINK-7 referencing [a Stackoverflow post|htt= ps://stackoverflow.com/questions/46573572/java-9-possible-to-have-2-modules= -with-same-name-on-module-path/46574200#46574200] to prove that module name= s must be unique. In fact, this Stackoverflow post says the exact opposite.= The bottom half of the post states that modules in separate directories **= are** allowed to have the same name. The bottom of the post concludes: > {quote}That makes it possible to have the same module in different direct= ories. > {quote} > It doesn't have to be the same module per-se. It is possible for two diff= erent implementations with the same module name to reside on the module pat= h, so long as the modules reside in different directory. This is useful for= "class shadowing". In my particular case, I ship a no-op implementation of= a module by default but users can insert a working implementation in front= of the module path to enable the feature. > Please reopen this issue or continue its work here. -- This message was sent by Atlassian JIRA (v7.6.3#76005)