maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Scholte (JIRA)" <j...@apache.org>
Subject [jira] [Issue Comment Deleted] (MNG-6350) Maven 3.5.2 Command Line mvn.cmd fails on path names containing round bracket "()" chars
Date Thu, 06 Dec 2018 21:24:01 GMT

     [ https://issues.apache.org/jira/browse/MNG-6350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Robert Scholte updated MNG-6350:
--------------------------------
    Comment: was deleted

(was: michael-o commented on a change in pull request #194: MNG-6350 - Test + System property
to disable global model cache
URL: https://github.com/apache/maven/pull/194#discussion_r238855845
 
 

 ##########
 File path: maven-core/src/main/java/org/apache/maven/project/DefaultProjectBuilder.java
 ##########
 @@ -355,7 +365,8 @@ private ModelSource createStubModelSource( Artifact artifact )
 
         ReactorModelPool modelPool = new ReactorModelPool();
 
-        InternalConfig config = new InternalConfig( request, modelPool );
+        InternalConfig config = new InternalConfig( request, modelPool,
+                useGlobalModelCache() ? getModelCache() : new ReactorModelCache() );
 
 Review comment:
   Rechecked the code, the surrouding class does. Isn't then the change above not wrong?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
)

> Maven 3.5.2 Command Line mvn.cmd fails on path names containing round bracket "()" chars
> ----------------------------------------------------------------------------------------
>
>                 Key: MNG-6350
>                 URL: https://issues.apache.org/jira/browse/MNG-6350
>             Project: Maven
>          Issue Type: Bug
>          Components: Command Line
>    Affects Versions: 3.5.2
>         Environment: Windows OS
>            Reporter: Markus Hoffrogge
>            Assignee: Robert Scholte
>            Priority: Major
>              Labels: windows
>         Attachments: mvn.cmd_roundBrackets_1.png, mvn.cmd_roundBrackets_2.png
>
>
> If the absolute path name of the -f command line parameter contains round bracket characters
"(" or ")", then the command line mvn.cmd fails with "... was unexpected at this time".
> The issue can be easily fixed in mvn.cmd, 3.5.2 for he appropriate echo statements:
> line 120: enclose %FILE_ARGS% by "" -> "%FILE_ARGS%"
> line 129: same for %POM_DIR% and %FILE_ARGS%
> The screenshots attached have been created with env var MAVEN_BATCH_ECHO=on.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message