maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] Tibor17 commented on a change in pull request #204: [SUREFIRE-1602] Surefire fails loading class ForkedBooter when using a sub-directory pom file and a local maven repo
Date Sun, 02 Dec 2018 11:57:34 GMT
Tibor17 commented on a change in pull request #204: [SUREFIRE-1602] Surefire fails loading
class ForkedBooter when using a sub-directory pom file and a local maven repo
URL: https://github.com/apache/maven-surefire/pull/204#discussion_r238095522
 
 

 ##########
 File path: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/JarManifestForkConfiguration.java
 ##########
 @@ -103,7 +103,7 @@ private File createJar( @Nonnull List<String> classPath, @Nonnull
String startCl
         {
             file.deleteOnExit();
         }
-        Path parent = file.getParentFile().toPath();
+        Path parent = file.getParentFile().toPath().normalize();
 
 Review comment:
   I will guide you on how to write an IT in the evening.
   Meanwhile I would like to see the path. Did you grab the path from debugger?
   I have used another project and the path was `d:\vcs\release\.\surefire-1605\target\classes`
in my case but the project works without the fix. Maybe the path in user's project was so
relative that a parent could not be found but this is only my suspicion.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message