From issues-return-139744-archive-asf-public=cust-asf.ponee.io@maven.apache.org Fri Nov 2 13:41:06 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id ED3B0180677 for ; Fri, 2 Nov 2018 13:41:05 +0100 (CET) Received: (qmail 64289 invoked by uid 500); 2 Nov 2018 12:41:05 -0000 Mailing-List: contact issues-help@maven.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@maven.apache.org Delivered-To: mailing list issues@maven.apache.org Received: (qmail 64278 invoked by uid 99); 2 Nov 2018 12:41:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Nov 2018 12:41:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 7E9A81A325A for ; Fri, 2 Nov 2018 12:41:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.001 X-Spam-Level: X-Spam-Status: No, score=-109.001 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, KAM_NUMSUBJECT=0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id mzLyr5xd3rm6 for ; Fri, 2 Nov 2018 12:41:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id B97625F470 for ; Fri, 2 Nov 2018 12:41:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 0E74EE0E87 for ; Fri, 2 Nov 2018 12:41:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id A055027765 for ; Fri, 2 Nov 2018 12:41:00 +0000 (UTC) Date: Fri, 2 Nov 2018 12:41:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@maven.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (SUREFIRE-1588) Surefire manifest jar classloading broken on latest Debian/Ubuntu Java8 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SUREFIRE-1588?page=3Dcom.atlass= ian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1= 6673039#comment-16673039 ]=20 ASF GitHub Bot commented on SUREFIRE-1588: ------------------------------------------ Tibor17 commented on a change in pull request #197: SUREFIRE-1588 Patch (Ja= va7) URL: https://github.com/apache/maven-surefire/pull/197#discussion_r23036022= 4 =20 =20 ########## File path: maven-surefire-common/src/main/java/org/apache/maven/plugin/sur= efire/booterclient/JarManifestForkConfiguration.java ########## @@ -114,7 +115,7 @@ private File createJar( @Nonnull List classPat= h, @Nonnull String startCl { File file1 =3D new File( it.next() ); =20 - String uri =3D parent.relativize( file1.toPath() ).toStrin= g(); + String uri =3D URI.create( parent.relativize( file1.toPath= () ).toString() ).toASCIIString(); =20 Review comment: AFAIK our users, they won't see any warnings. So. We should write the lo= g down to a dump file, see `InPluginProcessDumpSingleton`. You need to spec= ify reports dir and pass it to the class. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. =20 For queries about this service, please contact Infrastructure at: users@infra.apache.org > Surefire manifest jar classloading broken on latest Debian/Ubuntu Java8 > ----------------------------------------------------------------------- > > Key: SUREFIRE-1588 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1588 > Project: Maven Surefire > Issue Type: Bug > Affects Versions: 2.22.1 > Reporter: Cservenak, Tamas > Priority: Major > > See issue [1], but in short: latest Java8 on Ubuntu/Debian/Mint family of= Linuxes (am on Mint, Ubuntu derivative) contains this patch [3], and eforc= es Manifest class path entries to be relative, as defined in [2]. > Hence, surefire booter and rest of Maven classpath, that uses absolute UR= Ls are simply discarded. > Example error: > {noformat} > # Created at 2018-10-30T21:34:43.339 > Error: Could not find or load main class org.apache.maven.surefire.booter= .ForkedBooter{noformat} > using the new property {{-Djdk.net.URLClassPath.disableClassPathURLCheck= =3Ddebug}} clearly shows that all the entries from the surefire JAR are sim= ply ignored. > =C2=A0 > [1]=C2=A0[https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=3D911925] > [2]=C2=A0https://docs.oracle.com/javase/8/docs/technotes/guides/jar/jar.h= tml#classpath > [3]=C2=A0[https://hg.openjdk.java.net/jdk/jdk/rev/27135de165ac] -- This message was sent by Atlassian JIRA (v7.6.3#76005)