From issues-return-139692-archive-asf-public=cust-asf.ponee.io@maven.apache.org Thu Nov 1 23:33:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id C872F180677 for ; Thu, 1 Nov 2018 23:33:04 +0100 (CET) Received: (qmail 64214 invoked by uid 500); 1 Nov 2018 22:33:03 -0000 Mailing-List: contact issues-help@maven.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@maven.apache.org Delivered-To: mailing list issues@maven.apache.org Received: (qmail 64203 invoked by uid 99); 1 Nov 2018 22:33:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Nov 2018 22:33:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 66A511A2E06 for ; Thu, 1 Nov 2018 22:33:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 5IHBPhvyvNIm for ; Thu, 1 Nov 2018 22:33:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 7797B5F1D4 for ; Thu, 1 Nov 2018 22:33:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id A9322E0D9F for ; Thu, 1 Nov 2018 22:33:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 6CED327765 for ; Thu, 1 Nov 2018 22:33:00 +0000 (UTC) Date: Thu, 1 Nov 2018 22:33:00 +0000 (UTC) From: =?utf-8?Q?Herv=C3=A9_Boutemy_=28JIRA=29?= To: issues@maven.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (MNG-6059) Important use cases not covered, as child.inherit.append.path affects all children MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MNG-6059?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:all-tabpanel ] Herv=C3=A9 Boutemy updated MNG-6059: ------------------------------- Description:=20 The {{child.inherit.append.path}} attribute introduced with MNG-5951 unfort= unately does not support the use case where the children of the element wit= h the attribute should follow different inheritance rules. Take a typical c= onfiguration for Github, for example (taken from <[http://central.sonatype.= org/pages/requirements.html]>): {noformat} scm:git:git://github.com/simpligility/ossrh-demo.git scm:git:ssh://github.com:simpligility/ossrh-demo.git= http://github.com/simpligility/ossrh-demo/tree/master {noformat} If the {{ossrh-demo.git}} repository contains a child module called {{some-= module}}, then that child=E2=80=99s {{scm/url}} should become {{[http://git= hub.com/simpligility/ossrh-demo/tree/master/some-module]}} as per the norma= l inheritance rules, but both the {{scm/connection}} and {{scm/developerCon= nection}} URLs should remain unchanged. Unfortunately, this is not possible with {{*child*.inherit.append.path}}, w= hich acts on all children simultaneously. IMHO, this is a conceptual problem. In particular, setting {{child.inherit.= append.path}} on the *root* element to just control a single child ({{proje= ct/url}}) feels wrong, as the attribute is in all likelihood not even locat= ed close to the {{}} element it controls. h1. Implemented Solution {code:xml} ... ... ... ... ... {code} was: The {{child.inherit.append.path}} attribute introduced with MNG-5951 unfort= unately does not support the use case where the children of the element wit= h the attribute should follow different inheritance rules. Take a typical c= onfiguration for Github, for example (taken from ): {noformat} scm:git:git://github.com/simpligility/ossrh-demo.git scm:git:ssh://github.com:simpligility/ossrh-demo.git= http://github.com/simpligility/ossrh-demo/tree/master {noformat} If the {{ossrh-demo.git}} repository contains a child module called {{some-= module}}, then that child=E2=80=99s {{scm/url}} should become {{http://gith= ub.com/simpligility/ossrh-demo/tree/master/some-module}} as per the normal = inheritance rules, but both the {{scm/connection}} and {{scm/developerConne= ction}} URLs should remain unchanged. Unfortunately, this is not possible with {{*child*.inherit.append.path}}, w= hich acts on all children simultaneously. IMHO, this is a conceptual problem. In particular, setting {{child.inherit.= append.path}} on the *root* element to just control a single child ({{proje= ct/url}}) feels wrong, as the attribute is in all likelihood not even locat= ed close to the {{}} element it controls. > Important use cases not covered, as child.inherit.append.path affects all= children > -------------------------------------------------------------------------= --------- > > Key: MNG-6059 > URL: https://issues.apache.org/jira/browse/MNG-6059 > Project: Maven > Issue Type: Improvement > Components: Inheritance and Interpolation > Affects Versions: 3.6.0 > Environment: Apache Maven 3.4.0-SNAPSHOT (227085283b6379038ec16f4= cf9ad2e8869cef694; 2016-07-06T21:29:12+02:00) > Reporter: Andreas Sewe > Assignee: Herv=C3=A9 Boutemy > Priority: Major > Fix For: 3.6.1 > > > The {{child.inherit.append.path}} attribute introduced with MNG-5951 unfo= rtunately does not support the use case where the children of the element w= ith the attribute should follow different inheritance rules. Take a typical= configuration for Github, for example (taken from <[http://central.sonatyp= e.org/pages/requirements.html]>): > {noformat} > > scm:git:git://github.com/simpligility/ossrh-demo.git > scm:git:ssh://github.com:simpligility/ossrh-demo.g= it > http://github.com/simpligility/ossrh-demo/tree/master > > {noformat} > If the {{ossrh-demo.git}} repository contains a child module called {{som= e-module}}, then that child=E2=80=99s {{scm/url}} should become {{[http://g= ithub.com/simpligility/ossrh-demo/tree/master/some-module]}} as per the nor= mal inheritance rules, but both the {{scm/connection}} and {{scm/developerC= onnection}} URLs should remain unchanged. > Unfortunately, this is not possible with {{*child*.inherit.append.path}},= which acts on all children simultaneously. > IMHO, this is a conceptual problem. In particular, setting {{child.inheri= t.append.path}} on the *root* element to just control a single child ({{pro= ject/url}}) feels wrong, as the attribute is in all likelihood not even loc= ated close to the {{}} element it controls. > h1. Implemented Solution > {code:xml} > ... > child.scm.developerConnection.inherit.append.path=3D"false" > child.scm.url.inherit.append.path=3D"false"> > ... > ... > ... > > > > ... > > > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)