From issues-return-140258-archive-asf-public=cust-asf.ponee.io@maven.apache.org Sun Nov 11 08:42:27 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 87375180645 for ; Sun, 11 Nov 2018 08:42:26 +0100 (CET) Received: (qmail 14774 invoked by uid 500); 11 Nov 2018 07:42:25 -0000 Mailing-List: contact issues-help@maven.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@maven.apache.org Delivered-To: mailing list issues@maven.apache.org Received: (qmail 14752 invoked by uid 99); 11 Nov 2018 07:42:25 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 11 Nov 2018 07:42:25 +0000 From: GitBox To: issues@maven.apache.org Subject: [GitHub] Tibor17 commented on a change in pull request #196: [SUREFIRE-1585] [WIP] Resolve missing and align "JUnit 5" artifacts Message-ID: <154192214461.32282.4734206464897404750.gitbox@gitbox.apache.org> Date: Sun, 11 Nov 2018 07:42:24 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Tibor17 commented on a change in pull request #196: [SUREFIRE-1585] [WIP] Resolve missing and align "JUnit 5" artifacts URL: https://github.com/apache/maven-surefire/pull/196#discussion_r232477165 ########## File path: surefire-its/src/test/java/org/apache/maven/surefire/its/JUnitPlatformEnginesIT.java ########## @@ -93,12 +93,10 @@ public void platform() throws VerificationException String testClasspath = "[DEBUG] test(compact) classpath:" + " test-classes" + " classes" - + " junit-jupiter-engine-" + jupiter + ".jar" + + " junit-jupiter-api-" + jupiter + ".jar" Review comment: Excellent, we should document a new user experience with examples: 1. with engine dependency 2. with API dependency (since of `3.0.0-M2`) Do we have third option we can document with this fix? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services