maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SUREFIRE-1585) Auto-resolve "missing" JUnit 5 artifacts
Date Sun, 11 Nov 2018 07:43:00 GMT

    [ https://issues.apache.org/jira/browse/SUREFIRE-1585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16682766#comment-16682766
] 

ASF GitHub Bot commented on SUREFIRE-1585:
------------------------------------------

Tibor17 commented on a change in pull request #196: [SUREFIRE-1585] [WIP] Resolve missing
and align "JUnit 5" artifacts
URL: https://github.com/apache/maven-surefire/pull/196#discussion_r232477165
 
 

 ##########
 File path: surefire-its/src/test/java/org/apache/maven/surefire/its/JUnitPlatformEnginesIT.java
 ##########
 @@ -93,12 +93,10 @@ public void platform() throws VerificationException
         String testClasspath = "[DEBUG] test(compact) classpath:"
                 + "  test-classes"
                 + "  classes"
-                + "  junit-jupiter-engine-" + jupiter + ".jar"
+                + "  junit-jupiter-api-" + jupiter + ".jar"
 
 Review comment:
   Excellent, we should document a new user experience with examples:
   1. with engine dependency
   2. with API dependency (since of `3.0.0-M2`)
   Do we have third option we can document with this fix?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Auto-resolve "missing" JUnit 5 artifacts
> ----------------------------------------
>
>                 Key: SUREFIRE-1585
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-1585
>             Project: Maven Surefire
>          Issue Type: Improvement
>          Components: JUnit 5.x support
>    Affects Versions: 2.22.1
>            Reporter: Christian Stein
>            Assignee: Christian Stein
>            Priority: Minor
>              Labels: features
>
> Providers should be able to enhance the test runtime by injecting "missing" artifacts
before executing tests.
>  
> For example, the JUnit Platform Provider should add "missing" Test Engine artifacts for
when users only depend on the API of a test framework.
>  * User test depends on *`junit-jupiter-api`* only? Provide *`junit-jupiter-engine`*
at test runtime -- automatically or via plugin deps.
>  * User test depends on *`junit-jupiter-params`* only? That pulls in *`junit-jupiter-api`*
transitively. Provide *`junit-jupiter-engine`* at test runtime -- automatically or via plugin
deps.
>  * User test depends on *`junit:junit:4.12`* only *AND* the JUnit Platform Provider is
forced? Provide *`junit-vintage-engine`* at test runtime -- automatically or via plugin deps.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message