maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Scholte (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MSHADE-291) shadedPattern applied multiples times when relocating the contents of META-INF/services files
Date Sat, 10 Nov 2018 08:55:00 GMT

    [ https://issues.apache.org/jira/browse/MSHADE-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16682279#comment-16682279
] 

Robert Scholte commented on MSHADE-291:
---------------------------------------

I would expect the issue to be in the {{ServicesResourceTransformer}}, the {{canRelocatePath()}}-method
should not take the shadedPattern into account.

> shadedPattern applied multiples times when relocating the contents of META-INF/services
files
> ---------------------------------------------------------------------------------------------
>
>                 Key: MSHADE-291
>                 URL: https://issues.apache.org/jira/browse/MSHADE-291
>             Project: Maven Shade Plugin
>          Issue Type: Bug
>    Affects Versions: 3.1.1
>            Reporter: Jan Luehe
>            Priority: Major
>              Labels: up-for-grabs
>
> Steps to reproduce:
> 1. Modified the test case for https://issues.apache.org/jira/browse/MSHADE-190, as follows:
> {code:java}
> diff --git a/pom.xml b/pom.xml
> index 746b700..aea9abb 100644
> --- a/pom.xml
> +++ b/pom.xml
> @@ -68,12 +68,12 @@
>              <plugin>
>                  <groupId>org.apache.maven.plugins</groupId>
>                  <artifactId>maven-shade-plugin</artifactId>
> -                <version>2.4</version>
> +                <version>3.1.1</version>
>                  <configuration>
>                      <relocations>
>                          <relocation>
> -                            <pattern>org.eclipse.*</pattern>
> -                            <shadedPattern>borg.eclipse.*</shadedPattern>
> +                            <pattern>org.eclipse</pattern>
> +                            <shadedPattern>org.eclipse1234</shadedPattern>
>                          </relocation>
>                      </relocations>
>                      <transformers>
> {code}
> 2. mvn package
> 3. jar -xvf target/shade-meta-tc-1.0-SNAPSHOT.jar META-INF/services
> 4. cat META-INF/services/org.osgi.framework.launch.FrameworkFactory
> The shaded service implementation class looks as follows: 
> {code:java}
> org.eclipse12341234.osgi.launch.EquinoxFactory
> {code}
> It appears that shadedPattern was applied twice.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message