maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] Jurrie commented on a change in pull request #2: Implement MRRESOURCES-102
Date Thu, 22 Nov 2018 18:34:40 GMT
Jurrie commented on a change in pull request #2: Implement MRRESOURCES-102
URL: https://github.com/apache/maven-remote-resources-plugin/pull/2#discussion_r235802216
 
 

 ##########
 File path: src/main/java/org/apache/maven/plugin/resources/remote/ProcessRemoteResourcesMojo.java
 ##########
 @@ -847,8 +853,7 @@ protected boolean copyResourceIfExists( File file, String relFileName,
VelocityC
                 }
                 else if ( resource.isFiltering() )
                 {
-
-                    MavenFileFilterRequest req = setupRequest( resource, source, file );
+                    MavenFileFilterRequest req = setupRequest( source, file, resource.isFiltering()
);
 
 Review comment:
   Thanks for the suggestion. This actually makes the third parameter 'true' for all invocations,
so it can be removed. 4a1a5219ea29a754600fa1aa9cdcaca9f059fec2

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message