maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] rfscholte commented on a change in pull request #23: [MRESOLVER-63] FileTransformer#transformData(File) should also throw TransformException
Date Wed, 14 Nov 2018 16:48:55 GMT
rfscholte commented on a change in pull request #23: [MRESOLVER-63] FileTransformer#transformData(File)
should also throw TransformException
URL: https://github.com/apache/maven-resolver/pull/23#discussion_r233528693
 
 

 ##########
 File path: maven-resolver-api/src/main/java/org/eclipse/aether/transform/FileTransformer.java
 ##########
 @@ -47,5 +46,5 @@
      * @param file the file with the original data
      * @return the transformed data
      */
-    InputStream transformData( File file ) throws IOException;
+    InputStream transformData( File file ) throws FileTransformationException;
 
 Review comment:
   Both IOException and TransformException must be thrown. Better not make it too explicit,
we might do other transformations as well in the future, not only filebased.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message