maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] Tibor17 commented on a change in pull request #196: [SUREFIRE-1585] [WIP] Resolve missing and align "JUnit 5" artifacts
Date Sun, 11 Nov 2018 07:42:24 GMT
Tibor17 commented on a change in pull request #196: [SUREFIRE-1585] [WIP] Resolve missing and
align "JUnit 5" artifacts
URL: https://github.com/apache/maven-surefire/pull/196#discussion_r232477165
 
 

 ##########
 File path: surefire-its/src/test/java/org/apache/maven/surefire/its/JUnitPlatformEnginesIT.java
 ##########
 @@ -93,12 +93,10 @@ public void platform() throws VerificationException
         String testClasspath = "[DEBUG] test(compact) classpath:"
                 + "  test-classes"
                 + "  classes"
-                + "  junit-jupiter-engine-" + jupiter + ".jar"
+                + "  junit-jupiter-api-" + jupiter + ".jar"
 
 Review comment:
   Excellent, we should document a new user experience with examples:
   1. with engine dependency
   2. with API dependency (since of `3.0.0-M2`)
   Do we have third option we can document with this fix?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message