maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] cstamas commented on a change in pull request #197: SUREFIRE-1588 Patch (Java7)
Date Thu, 01 Nov 2018 16:36:33 GMT
cstamas commented on a change in pull request #197: SUREFIRE-1588 Patch (Java7)
URL: https://github.com/apache/maven-surefire/pull/197#discussion_r230109074
 
 

 ##########
 File path: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/JarManifestForkConfiguration.java
 ##########
 @@ -111,7 +113,8 @@ private File createJar( @Nonnull List<String> classPath, @Nonnull
String startCl
             for ( Iterator<String> it = classPath.iterator(); it.hasNext(); )
             {
                 File file1 = new File( it.next() );
-                String uri = file1.toURI().toASCIIString();
+
+                String uri = parent.relativize( file1.toPath() ).toString();
 
 Review comment:
   Great observations, thanks! I completely forgot about Windows drive letters thingy (am
on Linux). Applied your proposal with some changes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message