maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MPOM-211) Add (server-)id property to Scm model
Date Mon, 29 Oct 2018 20:16:00 GMT

    [ https://issues.apache.org/jira/browse/MPOM-211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667695#comment-16667695
] 

ASF GitHub Bot commented on MPOM-211:
-------------------------------------

silkentrance edited a comment on issue #190: MPOM-211
URL: https://github.com/apache/maven/pull/190#issuecomment-434056335
 
 
   Aside Note:
   
   Looking at maven-scm-api/AbstractScmMojo, I see that it supports the server id via the
repository host:port parameter, looking up the required credentials via that id.
   
   Having Scm model support the id property would require the AbstractScmMojo to also look
for an optional id and prefer that over the host:port that is currently being used for looking
up the credentials from settings.xml/servers.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add (server-)id property to Scm model
> -------------------------------------
>
>                 Key: MPOM-211
>                 URL: https://issues.apache.org/jira/browse/MPOM-211
>             Project: Maven POMs
>          Issue Type: Improvement
>            Reporter: Carsten Klein
>            Priority: Major
>
> The maven-release plugin introduces the IdentifiedScm which includes the id property,
allowing the user to specify a server id for use with the lookup of credentials that can be
set securely in the maven settings.xml.
> This is a nice feature to have on the original Scm model as well and it will leverage
some security issues that we have with multiple other plugins operating on the Scm model.
> Currently, the user is required to specify the credentials either via the command line
or directly in the plugin configuration in the pom, or externally, using third party tools.
> And the Scm model should also implement the hashCode and equals() methods.
> Of course this will require also changes to the existing Scm plugins so that they can
make use of the new feature. Also, the maven-release plugin can be somewhat simplified by
this change.
>  
> QUESTION: should this then still be the POM version 4.0.0 or is this then 4.1.0?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message