maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rostislav Krasny (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MSHARED-362) Support removing default manifest entries with maven-archiver plugin
Date Tue, 30 Oct 2018 15:58:00 GMT

    [ https://issues.apache.org/jira/browse/MSHARED-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668931#comment-16668931
] 

Rostislav Krasny commented on MSHARED-362:
------------------------------------------

Hi. Please consider the attached [^MSHARED-362-01.patch]

It introduces following changes:
 # The {{Built-By}} manifest property is now disabled by default
 # The {{Built-By}} manifest property could be enabled again with the previous behavior (e.g.
{{user.name}}) by following configuration of the maven-jar-plugin
{code:java}
<configuration>
     <archive>
         <manifest>
             <addBuiltBy>true</addBuiltBy>
         </manifest>
     </archive>
 </configuration>{code}

 # Value of the {{Built-By}} manifest property could be customized if enabled by following
{{builtByName}} new configuration property:
{code:java}
<configuration>
     <archive>
         <manifest>
             <addBuiltBy>true</addBuiltBy>
             <builtByName>build machine name</builtByName>
         </manifest>
     </archive>
 </configuration>{code}

Rationale:

 # Currently the {{Built-By}} manifest property usually is different on different machines
and this prevents repeating the build with the same internal content of JAR files.
 # Currently the {{Built-By}} manifest property has no really useful information. I think
a user may want to put a more useful information into that property, for example the build
machine name.
 # Using the {{user.name}} in the {{Build-By}} manifest property could be considered as privacy
issue.

Rest of the manifest properties discussed in this Jira ticket seems less problematic to me.
Let's start fixing the main issue with the {{Built-By}} manifest property and continue discussion
of the rest later.

> Support removing default manifest entries with maven-archiver plugin
> --------------------------------------------------------------------
>
>                 Key: MSHARED-362
>                 URL: https://issues.apache.org/jira/browse/MSHARED-362
>             Project: Maven Shared Components
>          Issue Type: Improvement
>          Components: maven-archiver
>    Affects Versions: maven-archiver-2.4.2, maven-archiver-2.5
>            Reporter: Richard Neish
>            Priority: Minor
>         Attachments: MSHARED-362-01.patch
>
>
> As described in the StackOverflow question at http://stackoverflow.com/q/25098307/274350
maven-archiver should allow the user to remove the default manifest entries, such as "Built-By:"
> Currently it is possible to set an empty value for these default entries, but not to
remove them from the manifest.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message