maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] plamentotev edited a comment on issue #2: [MJAR-238] Allow setting of module main class
Date Sat, 27 Oct 2018 17:14:35 GMT
plamentotev edited a comment on issue #2: [MJAR-238] Allow setting of module main class
URL: https://github.com/apache/maven-jar-plugin/pull/2#issuecomment-433637874
 
 
   @rfscholte if we check only in the root of the archive we may get false negatives. The
`module-info.class` can be in `META-INF/versions/` (I've updated the code so now it works
with multi-release jars as well). Maybe we can check  the sub-directories of `META-INF/versions/`
before evaluating the included/excluded files, but not sure if it is worth it. Especially
given that `majr` can handle regular Jar files as well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message