maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] khmarbaise commented on issue #42: MENFORCER-320 RequireProfileIdsExist check must not fail if no profiles are used
Date Fri, 05 Oct 2018 14:25:57 GMT
khmarbaise commented on issue #42: MENFORCER-320 RequireProfileIdsExist check must not fail
if no profiles are used
URL: https://github.com/apache/maven-enforcer/pull/42#issuecomment-427384154
 
 
   Good catch. There are two things. First would you please create at least on integration
test which proves the fix and second please squash your commits into a single one...furthermore
please make your commit message look like this:
   ```
   [MENFORCER-320] - Subject of the ticket
    Optional supplemental explanations
   ```
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message