From issues-return-138425-archive-asf-public=cust-asf.ponee.io@maven.apache.org Sun Sep 30 18:53:09 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id DC731180677 for ; Sun, 30 Sep 2018 18:53:08 +0200 (CEST) Received: (qmail 14128 invoked by uid 500); 30 Sep 2018 16:53:07 -0000 Mailing-List: contact issues-help@maven.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@maven.apache.org Delivered-To: mailing list issues@maven.apache.org Received: (qmail 14103 invoked by uid 99); 30 Sep 2018 16:53:07 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 30 Sep 2018 16:53:07 +0000 From: GitBox To: issues@maven.apache.org Subject: [GitHub] plamentotev commented on issue #2: [MJAR-238] Allow setting of module main class Message-ID: <153832638728.21238.4922915457916048954.gitbox@gitbox.apache.org> Date: Sun, 30 Sep 2018 16:53:07 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit plamentotev commented on issue #2: [MJAR-238] Allow setting of module main class URL: https://github.com/apache/maven-jar-plugin/pull/2#issuecomment-425734635 Hi, this PR is obviously work in progress - I'll add tests and documentation later. I've created it so I can gather early feedback. The proposed solution will use the main class set in the manifest as module main class. This is related to the changes proposed in Plexus Archiver - codehaus-plexus/plexus-archiver#102 What do you think? if you approve this solution I'll merge the pull request in Plexus Archiver and create new release. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services