maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] hboutemy commented on a change in pull request #180: better performant for some Collection operations
Date Sun, 09 Sep 2018 08:17:58 GMT
hboutemy commented on a change in pull request #180: better performant for some Collection
operations
URL: https://github.com/apache/maven/pull/180#discussion_r216150888
 
 

 ##########
 File path: maven-core/src/test/java/org/apache/maven/lifecycle/internal/stub/MojoExecutorStub.java
 ##########
 @@ -50,10 +50,7 @@ public void execute( MavenSession session, MojoExecution mojoExecution,
ProjectI
     public void execute( MavenSession session, List<MojoExecution> mojoExecutions,
ProjectIndex projectIndex )
         throws LifecycleExecutionException
     {
-        for ( MojoExecution mojoExecution : mojoExecutions )
-        {
-            executions.add( mojoExecution );
-        }
+        executions.addAll(mojoExecutions);
 
 Review comment:
   missing parenthesis: please add
   (since it's a test, Checkstyle does not enforce our convention, but it's better to keep
it consistent, please)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message